majestrate / XD

meme bittorrent client
https://xd-torrent.github.io/
MIT License
241 stars 25 forks source link

Resolver is not exist in go < 1.10. #72

Closed r4sas closed 2 years ago

r4sas commented 5 years ago

https://github.com/majestrate/XD/blob/baa497aea9146af703cc56434c2bc02077a19814/src/xd/lib/network/inet/inet.go#L21

:thinking: inet.go:21: undefined: net.Resolver

$ go version
go version go1.7.4 linux/amd64
sevospl commented 5 years ago

I'm facing the same issue as well.

src/xd/lib/network/inet/inet.go:21: undefined: net.Resolver Makefile:58: recipe for target 'XD' failed

uname -a Linux raspberrypi 4.14.98-v7+ #1200 SMP Tue Feb 12 20:27:48 GMT 2019 armv7l GNU/Linux

go version go version go1.7.4 linux/arm

Any idea on this?

l-n-s commented 5 years ago

Dependencies

GNU Make GO 1.6 or higher

Type net.Resolver was added in 1.8, so I guess XD needs to bump go dependency version to 1.8 ?

majestrate commented 5 years ago

On Mon, May 27, 2019 at 02:54:52AM -0700, l-n-s wrote:

Dependencies

GNU Make GO 1.6 or higher

Type net.Resolver was added in 1.8, so I guess XD needs to bump go dependency version to 1.8 ?

yea i believe i do need to

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/majestrate/XD/issues/72#issuecomment-496155219

sevospl commented 5 years ago

Awesome, I've upgraded Go to the newest version and I was able to compile this. Thanks :)

r4sas commented 5 years ago

I think better add vendored version of net package.

majestrate commented 5 years ago

we could also do a shim layer too @r4sas if you want to code one up

l-n-s commented 5 years ago

tbh there's no need to, it's a build-time dependency, and most of the users will use prebuilt binaries anyway