search

majestrate / nntpchan

nntp based decentralized imageboard
MIT License
57 stars 3 forks source link

spurious assert in srndv2 makefile #148

Closed tidux closed 7 years ago

tidux commented 7 years ago

In contrib/backends/srndv2/Makefile:

assert-go:
    test $)VERSION = go1.9Th

Not only is this prima facie retarded, it's not even a required check. The srndv2 binary builds and runs fine with both older (1.7.4) and newer (1.9.1) versions of go. Commenting out the test is sufficient to fix the build process

majestrate commented 7 years ago

Yeah that check was for someone else, probably need to remove that now thnx for reminder On Mon, Oct 23, 2017 at 10:11:00PM -0700, Tidux wrote:

In contrib/backends/srndv2/Makefile:

assert-go: test $)VERSION = go1.9Th

Not only is this prima facie retarded, it's not even a required check. The srndv2 binary builds and runs fine with both older (1.7.4) and newer (1.9.1) versions of go. Commenting out the test is sufficient to fix the build process

— You are receiving this because you are subscribed to this thread. Reply to this email directly, [1]view it on GitHub, or [2]mute the thread.

Reverse link: [3]unknown

References

Visible links

  1. https://github.com/majestrate/nntpchan/issues/148
  2. https://github.com/notifications/unsubscribe-auth/AAefxXMT9C9YeKNGCSNSzHbO78Nd5NPuks5svXFkgaJpZM4QD2sD
  3. https://github.com/majestrate/nntpchan/issues/148
majestrate commented 7 years ago

fixed in https://github.com/majestrate/nntpchan/commit/3b83f184eab6b002e7eb3eb177524ac965aa1600