majikat768 / HuntStatsLogger

stats logger for Hunt: Showdown
MIT License
62 stars 7 forks source link

Partial name searching #69

Open timpatullock opened 1 year ago

timpatullock commented 1 year ago

Interested to hear your thoughts on whether having partial search would be useful for hunter data, specifically in the case that hunters use annoying characters (looking at you ) which makes them much harder to search for in the moment. Not a complete implementation and rather ugly since it's using a view not intended for multiple hunters.

image image

Also tightened up the SameTeamCount to use profileid instead of steam_name since players can change their name at-will but I believe the profileid is a bit more "locked in"

majikat768 commented 1 year ago

This looks great, thanks! One issue is when there are a lot of results, like if you were to just search 'E', the popup window extends past the bottom of the screen so the OK button is hidden....I think making it scrollable, and setting the maximum height to be equal to the main window would help. Also maybe adding an 'X' button in the top right.

timpatullock commented 1 year ago

Yep, I'll have a look at adding those elements in

timpatullock commented 1 year ago

Got back onto it, giving it a bit of a play around to see what works. Not 100% on the styling opportunities of the Qt library (new to that) so I'll try clean it up a bit. Looks like the following: image