search

majikayogames / SimpleTerrain

A simple terrain system created for Godot 4.
Creative Commons Zero v1.0 Universal
27 stars 3 forks source link

Follow the godot style guide #3

Closed KoB-Kirito closed 2 months ago

KoB-Kirito commented 2 months ago

Could you follow the style guide? Especially the snake_case folder and file names? https://docs.godotengine.org/en/stable/tutorials/scripting/gdscript/gdscript_styleguide.html

majikayogames commented 2 months ago

Not high on my to do list but if someone else wants to make a PR for this I'll accept it. I want the add-on itself and its folder to remain SimpleTerrain though because that's how I like to name my add-ons. Not gonna change all of them. I usually do SimpleAddonName.

KoB-Kirito commented 2 months ago

That's the main thing bothering me. Why not stay with the convention. It's there to unify things. Instead everybody brews their own brew.

It's there for a reason. Changes in casing can f up github. It's anoying when working with teams.

Do as you like, but in the end it's what caused us to not use this addon.

majikayogames commented 2 months ago

You are free to fork it. It's just something i made for myself. You can change the name and even the license, it's public domain.