search

majikthys / log4j2-logstash-jsonevent-layout

Log4J2 Layout as a Logstash "json_event"
Other
40 stars 34 forks source link

Compacted log events on separated lines should be treated as individual ... #4

Closed michaelsembwever closed 10 years ago

michaelsembwever commented 10 years ago

Compacted log events on separated lines should be treated as individual json objects.

The comma at the end of each line breaks the reading of each line if strict json formatting is required. The counter argument is that this breaks the json formatting of the file. But the file is always invalid as it always has a trailing comma. Otherwise this change only applies to compact && newline configurations.

This is an addition to commit a674ae80

This pull request includes the removal of trailing whitespace on other lines. (to view the pull request append "?w=1" to the url)

majikthys commented 10 years ago

Excellent, I'll review and merge this weekend. Thank you.

majikthys commented 10 years ago

agreed