search

majintao0131 / yaml-cpp

Automatically exported from code.google.com/p/yaml-cpp
MIT License
0 stars 0 forks source link

[PATCH] CMake buildsystem improvements #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hello again,

Attached are some CMake buildsystem improvements.
Using these I've created an initial yaml-cpp package for Exherbo [1].

You can also find those patches in my git mirror [2].

[1] http://git.exherbo.org/?p=dev/ingmar.git;a=tree;f=packages/dev-libs/libyaml
[2] http://github.com/ingmarv/yaml-cpp/tree/master

Looking forward to comments,
Ingmar

Original issue reported on code.google.com by ing...@exherbo.org on 29 May 2009 at 10:27

Attachments:

GoogleCodeExporter commented 9 years ago 
Patched the first three, and they work well - thanks!
For the testing patch, I tried it and ran `make test`, but I got the output

{{{
Running tests...
Start processing tests
Test project /path/to/yaml-cpp/build
No tests were found!!!
}}}

What am I doing wrong? (This is the first time I've used CMake for testing)

Original comment by jbe...@gmail.com on 29 May 2009 at 11:08

GoogleCodeExporter commented 9 years ago 
Sorry, my bad, I tweaked the patch after testing & broke it.

enable_testing() needs to go before add_test(), so it needs to go somewhere 
before we add_directory(yaml-
reader)

Fixed patch attached!

Original comment by ing...@exherbo.org on 29 May 2009 at 11:48

Attachments:

GoogleCodeExporter commented 9 years ago 
Gotcha; it's patched. Now I see why you opened the bug about the yaml-reader 
directory 
:)

Original comment by jbe...@gmail.com on 30 May 2009 at 2:42