search

majintao0131 / yaml-cpp

Automatically exported from code.google.com/p/yaml-cpp
MIT License
0 stars 0 forks source link

Write(_Null) naming conflicts #171

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What is the problem?

Emitter& Write(const _Null& null) - using several libraries that define 'null' 
as a macro, the yaml library will generate compilation errors. Plus, generally 
bad practice to name a variable 'null'.

What version of the product are you using? On what operating system?

Latest master branch (not sure of the version, it's not printed anywhere)

Original issue reported on code.google.com by jballard...@gmail.com on 19 Sep 2012 at 11:50

GoogleCodeExporter commented 9 years ago 
Sure, it's not a bad idea to change it here. But you should complain to those 
libraries that leak macros of common words - surely that's "worse practice".

Original comment by jbe...@gmail.com on 20 Sep 2012 at 12:47

GoogleCodeExporter commented 9 years ago 
It goes both ways ;) I'll make a note of it to open up tickets there, but why 
be another library that does it? ;)

Original comment by jballard...@gmail.com on 20 Sep 2012 at 10:05

GoogleCodeExporter commented 9 years ago 
Fixed, r10220ed54aa8.

Original comment by jbe...@gmail.com on 9 Nov 2012 at 12:42