majkinetor / au-packages

Chocolatey packages by majkinetor
https://gist.github.com/majkinetor/a700c70b8847b29ebb1c918d47ee4eb1
GNU General Public License v2.0
66 stars 45 forks source link

Signal installed/upgraded but parameters ignored #207

Closed 360path closed 2 years ago

360path commented 2 years ago

I have Chocolatey GUI 0.19.0.0 installed and upgraded Signal to 5.28.0 and noticed that it did not apply the parameters NoAutoUpdate and NoShortcut seem to have been ignored. I don't know whether this was already the case with previous versions, but I noticed just now. This means, no corresponding entry in the host file was created and a desktop shortcut was placed.

How can I check (and edit) the supposed parameters on install/upgrade of a package when using the community repository?

majkinetor commented 2 years ago

U should use --use-remembered-arguments but I think it sometimes doesn't work correctly (not sure tho).

https://github.com/chocolatey/choco/issues/797

U can enable this forever using choco feature:

[x] useRememberedArgumentsForUpgrades - Use Remembered Arguments For Upgrades - When running upgrades, use arguments for upgrade that were used for installation ('remembered'). This is helpful when running upgrade for all packages. Available in 0.10.4+. This is considered in preview for 0.10.4 and will be flipped to on by default in a future release.

NOTE: Its not flipped on by default AFAIK so far although its years it was introduced. I wonder when will it happen (/cc @gep13)

360path commented 2 years ago

Thank you for the information!

I have useRememberedArgumentsForUpgrades turned on.

Is there a way to add arguments in Chocolatey GUI during install and/or upgrade of a package? Or do I have to go into CLI for that?

majkinetor commented 2 years ago

I don't use GUI, can't help you with that.

gep13 commented 2 years ago

@360path said... Is there a way to add arguments in Chocolatey GUI during install and/or upgrade of a package?

There is an issue in the Chocolatey GUI repository to provide this functionality, and it should ship in the next version of Chocolatey GUI which will ship early this year:

https://github.com/chocolatey/ChocolateyGUI/issues/545

@majkinetor said... Its not flipped on by default AFAIK so far although its years it was introduced. I wonder when will it happen

We have recently discussed this very issue, and this will be flipped on by default once we close out the last remaining issue with this particular feature, and monitor it for any further issues. There is an open PR for the last known issue here:

https://github.com/chocolatey/choco/pull/2484

360path commented 2 years ago

@gep13 said:

@360path said... Is there a way to add arguments in Chocolatey GUI during install and/or upgrade of a package?

There is an issue in the Chocolatey GUI repository to provide this functionality, and it should ship in the next version of Chocolatey GUI which will ship early this year:

chocolatey/ChocolateyGUI#545

Thanks for pointing that out. Looking forward to that feature.

Meanwhile, maybe you can help with this or point me to somewhere I could get an answer: so, I used the CLI and passed the arguments. But as I already was on the latest version, it probably did nothing (at least, no Hosts file edit was performed). How can I check/make sure that next time upgrade is called for Signal (or any specific package for that matter), useRememberedArgumentsForUpgrades should be invoked and the previous arguments/parameters used again?

gep13 commented 2 years ago

The persisted arguments are stored in the .chocolatey folder, which you can find here:

C:\ProgramData\chocolatey\.chocolatey

In there, there should be a folder for the Signal package that you just installed, and in that folder, there should be a .arguments file. This is where the persisted arguments are stored, however, they will be encrypted. There isn't an "easy" way to unencrypt these today, however, that is a new feature that will be shipping in the next version of Chocolatey GUI.

majkinetor commented 2 years ago

I wrote above:

but I think it sometimes doesn't work correctly (not sure tho).

Now I see this is related to open PR @gep13 mentioned, and until it is merged, mass update is basically unusable.