search

majkinetor / au

Chocolatey Automatic Package Updater Module
GNU General Public License v2.0
227 stars 71 forks source link

Plugin GitReleases fails #227

Closed nils-a closed 3 years ago

nils-a commented 3 years ago

My build log looks like this:

Commiting
[test/set-env 5b3bd9d] AU: 1 updated - cleanmgrplus [skip ci] https://gist.github.com/be944da6cbb50300f2e3114bf35724a0/6850824cd899db1bd618afa98268a18fe5da9e14
 2 files changed, 4 insertions(+), 4 deletions(-)
Pushing changes

Running GitReleases
Creating the new release cleanmgrplus-1.36.1141...
  ERROR:  
    {"message":"Validation Failed","errors":[{"resource":"Release","code":"custom","field":"tag_name","message":"tag_name is not a valid tag"},{"resource":"Release","code":"custom","message":"Published releases must have a valid tag"},{"resource":"Release","code":"invalid","field":"target_commitish"}],"documentation_url":"https://docs.github.com/rest/reference/repos#create-a-release"}

I guess at least part of the error is me not having a master branch while GitReleases,ps1 expects one to always be there. https://github.com/majkinetor/au/blob/master/AU/Plugins/GitReleases.ps1#L51 reads:

"target_commitish" = "master"

While GitReleases is not new, I have never noticed the plugin to fail. (However, no releases were created, either.)

majkinetor commented 3 years ago

So if you change master to what you have, does it work ?

nils-a commented 3 years ago

Yes: https://github.com/nils-a/au-packages/releases/tag/cleanmgrplus-1.36.1141