Reportplugin - Githubissues

danmetzler commented 2 years ago

Closes #257

Adds Package_Source_Root_Url param to Markdown report type param in Report and also in History plugin
- People can add this to Update_All.ps1 script, and typically feed it an environment variable.
- $Package_Source_Root_Url defaults to https://github.com/$Github_UserRepo if not specified.
Links to packages in report are derived from $au_GalleryPackageRootUrl instead of hardcoded to https://chocolatey.org/packages
- $au_GalleryPackageRootUrl defaults to https://chocolatey.org/packages if not specified.
- Note: $au_GalleryPackageRootUrl was added to Update-Package.ps1 in previous commit e6d806e67eb337031df4d5629ddeed67c3a4a67b. This adds it to md_table function to generate the links to the package there in Markdown report.

Closes #244

Adds Package_Source_Branch param to Markdown report type param in Report plugin.
- Defaults to master if not specified.
- Typically this would be fed an environment variable, if needed.

Regarding #258 commit e14bb595528458bb585888c2ef610bd7e75fc1eb

In History plugin, --no-merges was added before the log command in the git log command. Caused git to complain about unrecognized option. I moved --no-merges after the log command and then it works fine.

All of this works in my environment now, and passes existing tests.

majkinetor commented 2 years ago

Just change the name of the params - there are no params with underscores now.

majkinetor commented 2 years ago

Also, u should add PR to the au-template later with those new options and comment next to it.

danmetzler commented 2 years ago

Renamed params:

(I think that's what you meant, right?)

danmetzler commented 2 years ago

Also, u should add PR to the au-template later with those new options and comment next to it.

I will take a look at the template, and work up a pull request.

majkinetor commented 2 years ago

On a second thought dont do that.

danmetzler commented 2 years ago

On a second thought dont do that.

ok. You mean don't do pull request on the template, right?

majkinetor commented 2 years ago

Yeah, I don't want to pile up params there that are probably going to be used rarely.

majkinetor / au