search

majlis-erc / manuForma

The manuForma application is designed to make TEI data creation and distributed editing faster and easier.
6 stars 1 forks source link

Bug: Look up #507

Closed mMoliere closed 9 months ago

mMoliere commented 9 months ago

@wsalesky The look up feature is causing a strange bug:

This file (MAJLIS-6.xml) has the name of an author, but we need to look up his ID: Screenshot 2024-01-23 at 16-14-28 Edit MS TEI Records

The search in look up turns up this result which is then selected and loaded: Screenshot 2024-01-23 at 16-14-52 Edit MS TEI Records

The result is that the entire author-element vanishes from the record: Screenshot 2024-01-23 at 16-15-26 Edit MS TEI Records

It gets even weirder. When I try to create a new author-element manuForma opens the persons look up feature! I then select "Add to record" …

Screenshot 2024-01-23 at 16-15-49 Edit MS TEI Records

… which creates a new blank author-element: Screenshot 2024-01-23 at 16-16-07 Edit MS TEI Records

But this is of no use. When I try to use the look up feature, the same thing happens: the element is deleted.

I have tested this bug both on Chrome and Firefox and with several files. It also when using look up with other fields (bibl, title, place).

wsalesky commented 9 months ago

@mMoliere Yikes! I will take a look. I have meetings today but hopefully I can get it sorted out by end of the day tomorrow.

mMoliere commented 9 months ago

@wsalesky Thank you!

wsalesky commented 9 months ago

@mMoliere I have the first part fixed. I'm not sure I understand the second part? 'It gets even weirder. When I try to create a new author-element manuForma opens the persons look up feature!' How are you creating the new author element?

In the meantime, please try the update here: https://github.com/majlis-erc/manuForma/pull/513

mMoliere commented 9 months ago

@wsalesky I created the new Author element in the menu bar of the collapsible. This feature also works fine now. Thank you!