search

majlis-erc / manuForma

The manuForma application is designed to make TEI data creation and distributed editing faster and easier.
6 stars 1 forks source link

Bibl look up adds URL to the wrong field #523

Closed mMoliere closed 9 months ago

mMoliere commented 9 months ago

@wsalesky In some subforms of manuscripts, the lookup adds the IDs to the wrong field:

In Heritage data and Bibliography, whenever the look up feature adds an entry the URL is added to an attribute of title.

Screenshot 2024-01-25 at 09-56-29 Edit MS TEI Records

What we want instead is that the URL is added to ptr/@target.

https://github.com/majlis-erc/manuForma/blob/a38920379f0dff9e461e4db5907aaf3976f8fd49/forms/templates/full-mss-template.xml#L216

and

https://github.com/majlis-erc/manuForma/blob/a38920379f0dff9e461e4db5907aaf3976f8fd49/forms/templates/full-mss-template.xml#L257

However, in Codicological definition the look up works as expected: the URL is added into the ptr element:

Screenshot 2024-01-25 at 09-53-31 Edit MS TEI Records

I have tried to understand the difference that makes it work there.

I tried to replace the instruction:

<lookup elementName="bibl" suppress="true"/>

with

<lookup api="/exist/apps/majlis/api/search/titleBibl?format=xml&amp;=collection=bibl&amp;q=" formURL="forms/mssTEI/lookup/titleBibl.xhtml" elementName="bibl" formName="titleBibl" lookupLabel="Look up reference"/>

But that didn't solve anything.

wsalesky commented 9 months ago

@mMoliere Has this been resolved? (With the other fix for the bibl lookup?)

mMoliere commented 9 months ago

@mMoliere Yes!