majlis-erc / manuForma

The manuForma application is designed to make TEI data creation and distributed editing faster and easier.
6 stars 1 forks source link

Works: Lookup for author vs. person #564

Closed mMoliere closed 5 months ago

mMoliere commented 5 months ago

@wsalesky In the works forms, manuForma needs to differentiate between authors and persons. As it works now, when a person record is linked to an author element, manuForma creates a child element persName with the ref attribute. Example:

https://github.com/majlis-erc/majlis-data/blob/4172b5e35de086180ef6d5eaf1766f2360e242e8/data/works/tei/test-1.xml#L88C1-L90C26

However, we want manuForma to add the string of the author name to the author element and the ref attribute. Meaning, the above example should look like this:

<author ref="https://jalit.org/person/11">Yešuʿa ben Yehuda<author>

Moreover, the works forms also contain a persName element that we use to reference other relevant people like compilers. So we need keep the functionality that we have now and expand it to work with authors.

wsalesky commented 5 months ago

See fix here: https://github.com/majlis-erc/srophe/pull/114

mMoliere commented 5 months ago

@wsalesky Yes, that worked. Thank you!