Use typeface name in page title

majodev / google-webfonts-helper

A Hassle-Free Way to Self-Host Google Fonts. Get eot, ttf, svg, woff and woff2 files + CSS snippets

https://gwfh.mranftl.com

MIT License

12.02k stars 420 forks source link

Use typeface name in page title #172

Open mxmason opened 1 year ago

mxmason commented 1 year ago

Summary

This PR:

turns the name of the app from a slug into a proper title (google-webfonts-helper --> Google Webfonts Helper)
the name of the selected typeface to the page title after the font data has been fetched. For example, the path /fonts/abel now yields a page titled Abel | Google Webfonts Helper.

Screenshots

Before	After

Related issues

Closes #169

majodev commented 1 year ago

Hi there, thanks for the PR.

| as separator is fine, however I would like to keep the original slug google-webfonts-helper (and the lowercased title without any dashes google webfonts helper). A dynamic title like Abel | google webfonts helper would be fine.

majodev commented 1 year ago

Bug: Navigating back to the root page does not clear out dynamically set font title.

mxmason commented 1 year ago

Got it. I’ll work on this, thanks!