search

majodev / google-webfonts-helper

A Hassle-Free Way to Self-Host Google Fonts. Get eot, ttf, svg, woff and woff2 files + CSS snippets
https://gwfh.mranftl.com
MIT License
12.02k stars 420 forks source link

Feature request: support for arm in docker images #175

Open mrocha98 opened 1 year ago

mrocha98 commented 1 year ago

Hello, I would like to suggest support for arm architecture in the docker images

I've tried to implement in my fork but I don't know how to setup ghcr correctly

Useful link: https://dev.to/cloudx/multi-arch-docker-images-the-easy-way-with-github-actions-4k54

majodev commented 1 year ago

Other archs should already be supported when building locally (no native arch deps within the Dockerfile). Simply follow Production Build.

Regarding publishing buildx images: I've currently no intention in adding that myself, as I've no way to test those images - I simply cannot guarantee any support for that architecture currently. Feel free to open a PR with a working updated Github Actions pipeline from your fork for publishing multi-arch images (with confirmed support) and I may reconsider.