search

major-mayer / imageconverter

A simple Nextcloud app to convert HEIC/ HEIF images to JPEG
GNU Affero General Public License v3.0
21 stars 2 forks source link

NC 28 Support #13

Closed petedenison closed 5 months ago

petedenison commented 8 months ago

Please add Official Support for Nextcloud Version 28

major-mayer commented 7 months ago

Hi, I'm working on it, but i need some more time. Nextcloud 28 introduces a lot of changes how apps that use file actions are registered and apparently also what is exposed in the OCA.Files namespace. https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.html

This is why this time a simple version bump is not enough and the app doesn't work anymore with Nextcloud 28. Thank you for your patience.

bcutter commented 5 months ago

@major-mayer Can you give at least a (rough) estimation on the time you need to restore compatibility? Thx.

major-mayer commented 5 months ago

Yeah sorry, should be done in the next 1-2 weeks. I was quite a lot on vacations the last weeks.

bcutter commented 5 months ago

That's great news. You'll make many (existing or future/currently waiting to update) NC v28 users happy :-)

major-mayer commented 5 months ago

All right, this was much more work than initially expected, especially because the new Files APIs and especially events are really badly documented. But finally I managed to solve all the obstacles that popped up during development and just released version 2.0.0 which is basically a complete rewrite of the frontend part. Things work a bit different now, but since I don't have access to the old OCA.Files APIs anymore in Nextcloud 28, there is no other way to do it.

On the plus side, the conversion action for multiple files is now only shown, when there are only HEIF/HEIC images in the selection, this was not possible before. Hope you like it and don't encounter too many bugs :slightly_smiling_face:

bcutter commented 5 months ago

Thank you for your work @major-mayer !

Unfortunately... https://github.com/major-mayer/imageconverter/issues/14

major-mayer commented 5 months ago

Should be fixed now, sorry for the inconvenience.

major-mayer commented 5 months ago

Maybe a bit of self-advertisement: If you like my app and the effort that I put into it, please consider rating in the Nextcloud app store. I've just discovered that I only have 3/5 stars :cry:

bcutter commented 5 months ago

Feel free :-) I'd like to vote.

But one needs to have a Nextcloud AppStore account to vote?

major-mayer commented 5 months ago

Yeah, unfortunately that's a requirement

petedenison commented 5 months ago

Thank you for your work on the upgrade.