major-mayer / imageconverter

A simple Nextcloud app to convert HEIC/ HEIF images to JPEG
GNU Affero General Public License v3.0
21 stars 2 forks source link

v2.0.0 can not be enabled #14

Closed bcutter closed 5 months ago

bcutter commented 5 months ago

After updating to v2.0.0 and when trying to enable the app, I get grafik

[PHP] Fehler: Class OCA\ImageConverter\AppInfo\Application contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\AppFramework\Bootstrap\IBootstrap::boot) at /var/www/nextcloud/apps/imageconverter/lib/AppInfo/Application.php#17
    POST /index.phpapps/enable
    von xxx.xxx.xxx.xxx von username um 05.04.2024, 20:52:09

This is logged every time clicking "Activate". Outcome with occ command not tested, likely the same :-(

SageSphinx63920 commented 5 months ago

Can confirm. My instance if not even accessible from now on getting a 500 HTTP code.

SageSphinx63920 commented 5 months ago

occ output:

root@gve-cloud:/var/www/nextcloud# sudo -u www-data php -f ./occ
PHP Fatal error:  Class OCA\ImageConverter\AppInfo\Application contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\AppFramework\Bootstrap\IBootstrap::boot) in /var/www/nextcloud/apps/imageconverter/lib/AppInfo/Application.php on line 17
{"reqId":"kJG5VzJ1xqbxJK8OZw0P","level":3,"time":"2024-04-05T22:09:29+00:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"Class OCA\\ImageConverter\\AppInfo\\Application contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\\AppFramework\\Bootstrap\\IBootstrap::boot) at /var/www/nextcloud/apps/imageconverter/lib/AppInfo/Application.php#17","userAgent":"--","version":"28.0.4.1","data":{"app":"PHP"}}

nginx error log:

2024/04/06 00:00:46 [error] 1311#1311: *14322 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Class OCA\ImageConverter\AppInfo\Application contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\AppFramework\Bootstrap\IBootstrap::boot) in /var/www/nextcloud/apps/imageconverter/lib/AppInfo/Application.php on line 17; PHP message: {"reqId":"V2llQEQpRZU6OpvmDpqw","level":3,"time":"2024-04-05T22:00:46+00:00","remoteAddr":"-","user":"--","app":"PHP","method":"GET","url":"/apps/richdocuments/settings/fonts.json","message":"Class OCA\\ImageConverter\\AppInfo\\Application contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (OCP\\AppFramework\\Bootstrap\\IBootstrap::boot) at /var/www/nextcloud/apps/imageconverter/lib/AppInfo/Application.php#17","userAgent":"COOLWSD HTTP Agent 23.05.10.1","version":"28.0.4.1","data":{"app":"PHP"}}" while reading response header from upstream, client: 127.0.0.1, server: cloud.grafen-von-eberstein.de, request: "GET /apps/richdocuments/settings/fonts.json HTTP/2.0", upstream: "fastcgi://unix:/run/php/php8.2-fpm-nextcloud.sock:", host: "-"
SageSphinx63920 commented 5 months ago

Further investigation shows that the boot method needed by IBootstrap is missing.

https://docs.nextcloud.com/server/latest/developer_manual/app_development/bootstrap.html#id2 https://docs.nextcloud.com/server/latest/developer_manual/app_development/bootstrap.html#booting-an-app

ninjazan420 commented 5 months ago

Can confirm. My instance if not even accessible from now on getting a 500 HTTP code.

hotfix is to go to /apps/ rename imageconverter to imageconverter_ and you should good to go if needed :)

major-mayer commented 5 months ago

Hey guys, sorry for the inconvenience. I accidentally deleted this boot method, because it contained no logic anyway. Somehow, I missed that it is a (abstract?) method required by the IBootstrap interface and did my last tests with a version before I deleted it. Lesson learned ...

I added it again in 2.0.1, and now you should be able to enable the app again.

bcutter commented 5 months ago

Yes great it is working again. Thanks a lot :-)