major / MySQLTuner-perl

MySQLTuner is a script written in Perl that will assist you with your MySQL configuration and make recommendations for increased performance and stability.
GNU General Public License v3.0
8.91k stars 1.28k forks source link

--updateversion needs valid mysql credentials to run #211

Closed jkavalik closed 8 years ago

jkavalik commented 8 years ago

Imho when --updateversion is specified, the script should just update itself, not run anything else. But it instead fails before the version check and download if valid credentials are not supplied.

jmrenouard commented 8 years ago

Hi @jkavalik
Nice idea :) Do you have a implementation code in mind ?

Thanks for your feedback !

mhasbini commented 8 years ago

@jkavalik Please check if this issue is fixed.

jmrenouard commented 8 years ago

@jkavalik @0xbsec Tests based on comment in related commit is ok for me.

Feel free to reopen this ticket if needed.

jkavalik commented 8 years ago

@0xbsec @jmrenouard works great, thank you!