Linux Patch to xmutil.cs on commit #9f245643 dated 26/04/2024 prevent color usage on Windows System

majorsilence / My-FyiReporting

Majorsilence Reporting, .NET report designer and viewer. Fork of fyireporting,

Apache License 2.0

347 stars 201 forks source link

Linux Patch to xmutil.cs on commit #9f245643 dated 26/04/2024 prevent color usage on Windows System #233

Closed alberti47 closed 6 months ago

alberti47 commented 6 months ago

function ColorFromHtml has been patched to return FIXED color.Acqua. The patch prevent on Windows to properly translate Html color. I dont' have information about the reason of this patch. I will Pull a request for cancel the patch unless different advise Regards

majorsilence commented 6 months ago

That sounds like incorrect behaviour in the code.

Send the pull request.

majorsilence commented 6 months ago

It is bad code. I should not of comitted it.

alberti47 commented 6 months ago

Sorry Yr reply not clear for me. Do You consider bad the original code ? Do You suggest to reimplement the function? (the original code world in Windows) or just remove patches inserted on commit 9f245643 ?

Regards