search

makaip / mathematix

A nodeblock-based math webapp.
https://makaip.github.io/mathematix/
GNU General Public License v3.0
4 stars 0 forks source link

QOL: shift + T and shift + U keybind #35

Closed AlexanderJCS closed 7 months ago

AlexanderJCS commented 7 months ago

Currently you can do shift + F to create a new function node, shift + R to make a new input node, shift + V to make a new variable node, etc.

I propose two more keybinds:

  1. shift + T for a new trig node block
  2. shift + U for a new unary node block

This should be a relatively simple addition, but please wait until I make my events.js refactor before making any changes. This will cause a merge conflict.

The section to modify is the window.addEventListener("keydown", (event) => event in the editor/events.js file.

AlexanderJCS commented 7 months ago

The code to modify is in editor/events.js: 

let keyMap = {
        "Escape": hideMenu,
        "A": () => showMenu(endX, endY),
        "F": newFunction,
        "R": newInput,
        "C": newOutput,
        "V": newVariable,
    }

The functions being referenced are in actions.js

@Valenciola @jcamille2023 both of you don't have many contributions - do one of you want to take this on?

Valenciola commented 7 months ago

Sure I’ll take this one on if Jossaya doesn’t

AlexanderJCS commented 7 months ago

He DMed me this morning about information about it, but haven't seen anything since. I'll update you if you can do it instead

jcamille2023 commented 7 months ago

That’s my bad I didn’t realize your refactor pull request was already merged

Sincerely, Jossaya Camille Student, FAU High School

From: AlexanderJCS @.> Sent: Saturday, March 2, 2024 11:01:00 PM To: makaip/mathematix @.> Cc: Jossaya Camille @.>; Mention @.> Subject: Re: [makaip/mathematix] QOL: shift + T and shift + U keybind (Issue #35)

            EXTERNAL EMAIL : Exercise caution when responding, opening links, or opening attachments.

He DMed me this morning about information about it, but haven't seen anything since. I'll update you if you can do it instead

— Reply to this email directly, view it on GitHubhttps://github.com/makaip/mathematix/issues/35#issuecomment-1975012644, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCH7XUUMAFDGUTC6FUGLG6DYWKN7ZAVCNFSM6AAAAABECXSPISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGAYTENRUGQ. You are receiving this because you were mentioned.Message ID: @.***>