search

makaip / mathematix

A nodeblock-based math webapp.
https://makaip.github.io/mathematix/
GNU General Public License v3.0
4 stars 0 forks source link

Update uiclasses.js #49

Closed jcamille2023 closed 7 months ago

jcamille2023 commented 7 months ago

Corrected the error which incorrectly returned '0' when graphing the variable x or any function related to it. image This is what the fix looks like. Let me know about any thoughts.

AlexanderJCS commented 7 months ago

Hi @jcamille2023, I fixed some issues with the implementation of this fix:

  1. If you try to select the Input node text box and type something, it doesn't register due to the commented out code.
  2. Also, invalid inputs to the Input box would return the invalid input, not 0.

I also fixed a NullPointerException when you press a key and do not have a node block selected. This was an issue with my original implementation, not your changes, but I decided to include it anyway because it goes with the issue theme of "throws a lot of errors" in the issue.

Let me know if the changes look good before I merge

AlexanderJCS commented 7 months ago

Going to merge because of the severity of the issue. If there are any more problems please create another issue/PR