Closed makaip closed 8 months ago
This is mostly fixed except for non-x inputs to trigonometric functions. Will close once that's completed
This is mostly fixed with my changes. I am going to close this issue, but we may re-open it since my changes are not 100% bug-free (but they're good enough for now)
When plotting graphs that contain asymptotes, such as
1/x
, or discontinuous functions, such as2 % x
, the functions still render as connected. This is because all graphs are assumed to be continuous, which causes gaps to be rendered as solid. The function for plotting functions can be found indraw.js
on lines 57 to 73.A potential solution could entail the utilization of discontinuous function detection algorithms, such as computing a value at n, then computing a value at
(n+1)
, and if(n+1)
does not exist, terminate the line and proceed with computing(n+2)
. This could potentially cause performance issues with rendering, as this would double the number of render calls. When implementing the "equals" node block, we may want to reconsider our rendering methods to align with the paper here.