recommend JSON::XS instead of conditionally requiring it

makamaka / JSON

perl implementation of JSON encoder/decoder

42 stars 40 forks source link

recommend JSON::XS instead of conditionally requiring it #10

Closed miyagawa closed 11 years ago

miyagawa commented 11 years ago

re https://rt.cpan.org/Public/Bug/Display.html?id=84876

This patch eliminates the whole "does it have JSON::XS and have C-compiler?" in Makefile.PL and instead just recommends JSON::XS.

I kept the pp_only logic there, and am not sure if this should also be taken into account and even remove it from recommends if pp-only is in effect.

miyagawa commented 11 years ago

BTW, this has already been discussed elsewhere, but

my $pp_only = $ENV{ PUREPERL_ONLY } || $ENV{ PERL_ONLY } || $ENV{ NO_XS };

isn't right, since PUREPERL_ONLY is a MakeMaker options, so it should be taken out from PERL_MM_OPT as well as @ARGV for the Makefile.PL.

makamaka commented 11 years ago

I merged this commit and removed all PP options from Makefile.PL. Thank you for suggestion.