search

makamaka / JSON

perl implementation of JSON encoder/decoder
42 stars 40 forks source link

Fix is_bool #34

Closed aidy closed 7 years ago

aidy commented 7 years ago

is_bool uses UNIVERSAL::isa, which isn't now recommended. This notably causes a problem with the string "JSON::PP::Boolean", which it incorrectly identifies as a boolean value.

Fix by using ->isa("JSON::PP::Boolean") as recommended by perldoc.

charsbar commented 7 years ago

Thanks for the patch, but JSON::backportPP is actually JSON::PP copied for backward compatibility. Could you modify and resend this patch to JSON::PP (https://github.com/makamaka/JSON-PP/ )?

aidy commented 7 years ago

Will do :)

charsbar commented 7 years ago

Applied your patch to JSON as well, by synching utility. Thanks.

aidy commented 7 years ago

No worries - thank you!