Closed kyzn closed 6 years ago
こんにちは。Thanks for your PR. The tests have lots of $]
checks to skip under older versions of Perl. These tests are taken almost verbosely from Text::CSV_XS, and Tux assured me that all the tests passed under Perl 5.6.1 (at least for Text::CSV_XS). Unfortutenaly I don't have 5.6.1 at hand, but I confirmed they passed for the latest Text::CSV under Perl 5.6.2 as well.
Could you change the minimum version to 5.006001?
Sure thing! Just a moment.
I updated my commits so that it's 5.6.1 now. Thanks!
Thanks!
こんにちは!It was a pleasure to meet you in Glasgow!
Thanks for maintaining Text-CSV. I've made some work on minimum perl version for my monthly CPAN Pull Request Challenge assignment.
I've found at Kwalitee that this module doesn't specify a minimum perl version at META.YML file. This can be seen here: https://cpants.cpanauthors.org/release/ISHIGAKI/Text-CSV-1.96
I've used
perlver
command to find what is the minimum perl version. Some test files have 5.8.0 due rule_open_scalar
. This is the highest throughout the repository.Another issue is that CSV_PP.pm explicitly specifies 5.5.0, whereas it actually needs 5.6.0 due rule
_regex
. First commit in this PR updates both CSV_PP.pm and Makefile.pl to 5.8.0.Second commit specifies 5.8 at Makefile.PL, which will make it appear on META.yml file. This fixes the kwalitee issue.
Please let me know if you'd rather keep it at 5.6, and use an older syntax in those test files. That should not be too difficult to implement.
Cheers!