search

makamys / CoreTweaks

A bunch of random bug fixes, optimizations and tweaks (1.7.10)
MIT License
45 stars 5 forks source link

Full transformer cache crashes with UniMixins #23

Open Goodbird-git opened 1 year ago

Goodbird-git commented 1 year ago

I have installed +unimixins-all-1.7.10-0.1.13.jar (latest version from the official mod github) and CoreTweaks-1.7.10-0.3.1.1+nomixin.jar And minecraft crashes with this crash-report crash-2023-11-04_14.31.02-client.txt Here is also a log latest.log Could you please fix this issue or tell me, what am I doing wrong?

Goodbird-git commented 1 year ago

I found out that it is because of S:transformerCacheMode=FULL However I wonder, why it is incompatible with UniMixins?

makamys commented 1 year ago

The full transformer cache replaces the transformer chain with a single transformer, which causes UniMixins to fail to find the Mixin transformer in there. It's not the default option for this reason, it has some compatibility issues (I think it breaks DragonAPI too).

Not sure how much I can do about this from CoreTweaks's side, and I wouldn't want to clutter up UniMixins with compat code for CoreTweaks's weirdness either. But I'll leave this issue open in case I think of something.

Goodbird-git commented 1 year ago

Alright, thanks!

Zilacon commented 1 year ago

Damn, was getting this exact issue. Was hoping to use the full transformer to speed up my massive modpack.