makamys / MAtmos

Minecraft Atmospheric sounds simulator (1.7.10, 1.12.2)
Other
27 stars 5 forks source link

Sounds keep cutting out with DynamicSounds installed #21

Closed TheDominooos closed 2 years ago

TheDominooos commented 2 years ago

game version: 1.12.2 forge version: 14.23.5.2860

Mods: OreLib-1.12.2-3.6.0.1 matmos-1.12.2-35.4.3.jar DynamicSurroundings-1.12.2-3.6.3

When many mobs are in one place (it starts happening with around 20 mobs), mob sounds cut out right after they start playing. This happens with or without any matmos sound packs loaded. The issue appears with less mobs (5-10 mobs) during rain. The issue persists with matmos disabled in the F4 menu.

What I tried:

makamys commented 2 years ago

https://github.com/makamys/MAtmos/blob/4272f3b62a2d31a9d6ffa22a2399587d58dfe9fe/projects/1.12/src/main/java/eu/ha3/matmos/core/mixin/MixinSoundManager.java#L33-L34

MAtmos is hardcoded to use 11 streaming channels and 21 normal channels, I'll have to change this to be configurable and respect other mods' settings.

makamys commented 2 years ago

https://github.com/makamys/MAtmos/suites/7956053091/artifacts/339879057 Try this new build. Now the settings set by Dynamic Surroundings or ExtendPolyphonyLimit are kept, plus the default channel count used when no other mod changes it has been doubled.

TheDominooos commented 2 years ago

The new build fixed the issue for me, thanks.