makamys / Neodymium

Reimplements chunk rendering using modern OpenGL features to improve performance (1.7.10)
Other
116 stars 10 forks source link

~~Crash with CoFHTweaks~~, Incompatibility with DragonAPI #9

Closed iamsoNewBee closed 1 year ago

iamsoNewBee commented 1 year ago

AS MY TITLE

makamys commented 1 year ago

I will see if it's something I can fix. In the meantime I can recommend ArchaicFix as an alternative that accomplishes similar things to CoFHTweaks and is fully compatible with Neodymium.

iamsoNewBee commented 1 year ago

I will see if it's something I can fix. In the meantime I can recommend ArchaicFix as an alternative that accomplishes similar things to CoFHTweaks and is fully compatible with Neodymium.

I ADDED FPSPLUS ,BETTERFPS AND FOAMFIX AND STH ELSE IN MY MOD PACK BUT BLOCK TEXTURES ARE MISSING.I WILL POST PICTURES LATER AND I AM NOT SURE IF IT HAVE TO DO WITH THOSE MODS.

iamsoNewBee commented 1 year ago
image image image image
iamsoNewBee commented 1 year ago

WHEN I AM MOVING ,THESE TEXTURES CONTINUE TWINKLING.WHEN I STOP ,THE MISSING PARTS CONTAIN

makamys commented 1 year ago

Strange, I've never seen that before. Does it happen when running Neodymium alone? If not, try removing the other mods until you find the one that causes the issue.

makamys commented 1 year ago

I doubt those mods would be causing it, since they don't directly affect rendering in any way. Can you post your fml-client-latest.log?

iamsoNewBee commented 1 year ago

I doubt those mods would be causing it, since they don't directly affect rendering in any way. Can you post your fml-client-latest.log?

SORRY I MADE A MISTAKE.IT`S PROBABLY CAUSED BY DRAGON API.

makamys commented 1 year ago

Oh, that seems more likely. It is known to affect rendering in strange ways, such as https://github.com/ReikaKalseki/Reika_Mods_Issues/issues/2879. It might help if you disable mipmapping.

iamsoNewBee commented 1 year ago

Oh, that seems more likely. It is known to affect rendering in strange ways, such as ReikaKalseki/Reika_Mods_Issues#2879. It might help if you disable mipmapping.

image

NO WORK QwQ

makamys commented 1 year ago

Does the issue go away if you remove DragonAPI (and all mods that depend on it), but keep Neodymium?

iamsoNewBee commented 1 year ago

Does the issue go away if you remove DragonAPI (and all mods that depend on it), but keep Neodymium?

PROBABLY YES

makamys commented 1 year ago

Hm, nope, I can't reproduce this. DragonAPI V31b + Neodymium 0.1.5 works fine (I had to disable the Forge splash, but that's an issue with DAPI itself).

iamsoNewBee commented 1 year ago

???let me do some more tests

iamsoNewBee commented 1 year ago

Hm, nope, I can't reproduce this. DragonAPI V31b + Neodymium 0.1.5 works fine (I had to disable the Forge splash, but that's an issue with DAPI itself).

image

TRY TO REPRODUCE BY THIS MODS LIST.

iamsoNewBee commented 1 year ago
image

more exactly

makamys commented 1 year ago

No issue with these (tested with the default configs). Can I see your log?

iamsoNewBee commented 1 year ago

No issue with these (tested with the default configs). Can I see your log?

TRY TO ADD THEM WITH DAPI?

makamys commented 1 year ago

Okay, I think I might know what's going on. If you have DragonAPI+GasStation+Neodymium or DragonAPI+Mixingasm+Neodymium, for some reason Neodymium fails to disable the vanilla world renderer, causing the world gets rendered twice. (Note how the water is more opaque than normal.) So it looks like you were right about GasStation and Mixingasm being related after all!

I want you to try something to confirm this: go to a place where you can see glitches, and press F4+V. This is a debug key shortcut that will disable Neodymium's renderer, revealing only whatever is left of the vanilla one. Take comparison screenshots with and without F4+V enabled, and post them here. For me, this is what happens when I press it.

makamys commented 1 year ago

I found a quick fix. Add this line to your config/mixingasm/transformer_inclusion_list.txt:

Reika.DragonAPI.ASM.*

(Example: )

This fixes the issue I described for me.

iamsoNewBee commented 1 year ago

I found a quick fix. Add this line to your config/mixingasm/transformer_inclusion_list.txt:

Reika.DragonAPI.ASM.*

(Example: )

This fixes the issue I described for me.

BY THE WAY ,BUGTORCH TAKES A PART,TOO.HOW TO DEAL WITH IT?(I DONT KNOW THE GRAMMER OF config/mixingasm/transformer_inclusion_list.txt:

iamsoNewBee commented 1 year ago

AS WELL AS CoreTweaks-1.7.10-0.2.6_1

iamsoNewBee commented 1 year ago

BUT THE ISSUE STILL EXISTS.I DONT KNOW WHICH MOD CAUSES IT ANYMORE. 2022-09-21-7.log.gz

makamys commented 1 year ago

I DONT KNOW THE GRAMMER OF config/mixingasm/transformer_inclusion_list.txt

Here's mine, just replace yours with this one transformer_inclusion_list.txt

iamsoNewBee commented 1 year ago

I DONT KNOW THE GRAMMER OF config/mixingasm/transformer_inclusion_list.txt

Here's mine, just replace yours with this one transformer_inclusion_list.txt

SORRY U MISUNDERSTOOD ME.THIS COULD ONLY TACKLE WITH DAPI`S ISSUE. BUT THERE ARE OTHER MODS CAUSEING THIS ISSUE LIKE WHAT I HAVE METHIONED ABROVE: CoreTweaks and bugtorch and so on.

makamys commented 1 year ago

So you're saying the issue is still present when you remove DAPI?

iamsoNewBee commented 1 year ago

AFTER I HAVING DONE WHAT U TOLE ME TO DO,DAPI AND Neodymium WORK CORRECTLY.BUT CoreTweaks and bugtorch MAY ALSO CAUSE THIS.(TESTED IN MY TESTING PACK) AND AFTER I REMOVING THEM IN MY WHOLE MODS PACK,I FOUND THAT THE ISSUE STILL PRESENTS LOL SO THERE MUST BE ANOTHER UNCERTAIN ONE

makamys commented 1 year ago

Hm... EnhancedVisuals or Triangulator, maybe?

iamsoNewBee commented 1 year ago

they work correctly

iamsoNewBee commented 1 year ago

AFTER I HAVING DONE WHAT U TOLE ME TO DO,DAPI AND Neodymium WORK CORRECTLY.BUT CoreTweaks and bugtorch MAY ALSO CAUSE THIS.(TESTED IN MY TESTING PACK) AND AFTER I REMOVING THEM IN MY WHOLE MODS PACK,I FOUND THAT THE ISSUE STILL PRESENTS LOL SO THERE MUST BE ANOTHER UNCERTAIN ONE

AND IF IT`S POSSIBLE THAT I COULD DO STH TO FIX THOSE IMCOMPAT LIKE WHAT I HAVE DONE TO DAPI?

makamys commented 1 year ago

I don't get any issue with CoreTweaks and BugTorch (I test with them normally). Using these:

iamsoNewBee commented 1 year ago

I don't get any issue with CoreTweaks and BugTorch (I test with them normally). Using these:

MAYBE YOU SHOULD ADD THEM WITH DAPI(EVEN IF IT`S FIXED) (ALSO WITH GASSTATION?)

makamys commented 1 year ago

Oh. Yeah, the issue comes back if i add BugTorch or CoreTweaks next to GasStation+Neodymium+DAPI. Weird.

makamys commented 1 year ago

Okay, I think I managed to fix the issue on my side now. It was caused by a totally useless hook in DAPI. Now this combo works fine: image

You can download the new build here: https://nightly.link/makamys/Neodymium/suites/8398953316/artifacts/371170082

Also, I realized that the Mixingasm config workaround isn't reliable at all, you should remove that Reika.DragonAPI.ASM.* line I told you to add. (DragonAPI's transformer is re-entrant so Mixin excludes it after its first run either way.)

iamsoNewBee commented 1 year ago

THX. I WILL HAVE A TRY :D

iamsoNewBee commented 1 year ago
image

EVERYTHING RETURNS TO NORMAL :D

makamys commented 1 year ago

Nice! I'll open another issue for the CoFHTweaks crash.

iamsoNewBee commented 1 year ago

OH I ALMOST FORGET THIS... XD

makamys commented 1 year ago

Eh, it's fine, it's better to track the issues separately. (The new one is #11)