Ruby 2.7 deprecation warnings

makandra / active_type

Make any Ruby object quack like ActiveRecord

MIT License

1.09k stars 74 forks source link

Ruby 2.7 deprecation warnings #123

Closed vkhalzov closed 3 years ago

vkhalzov commented 4 years ago

I have deprecation warnings in my app:

active_type-1.4.1/lib/active_type/record_extension/inheritance.rb:72: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
active_type-1.4.1/lib/active_type/record_extension/inheritance.rb:68: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

Stack: Ruby 2.7.1 Rails 6.0.3.2 active_type 1.4.1

kevinhq commented 3 years ago

It seems those warnings have been fixed in 1.4.2

I don't see it with this stack:

ruby 2.7.2 rails (6.0.3.4) active_type (1.4.2)

kratob commented 3 years ago

All of these warnings go away on Ruby 2.7.2. Since, as far as I'm aware, Rails itself has the same issues on Ruby 2.7.1 I'd consider this good enough. I've added tests for 2.7.2 and see no warnings at all.