Require active_support to have alias_chain when we're running with '--dry-run'.

makandra / cucumber_factory

Create records from Cucumber features without writing step definitions.

http://makandra.com/

MIT License

116 stars 15 forks source link

Require active_support to have alias_chain when we're running with '--dry-run'. #4

Closed pkoch closed 12 years ago

pkoch commented 12 years ago

Hello!

Tittle is self explanatory. :P

It wasn't very obvious how I should test this, so I didn't. If you want me to write them, please provide some guidance.

Cheers!

triskweline commented 12 years ago

Hi Paul. I'm not familiar with the --dry-run argument and I would like to understand the issue before I merge this. Can you tell me more?

pkoch commented 12 years ago

Hi! :)

Sure! In the docs (cucumber --help), you can read:

-d, --dry-run Invokes formatters without executing the steps. This also omits the loading of your support/env.rb file if it exists.

I use it to check which steps that I haven't implemented yet. I run this in my workflow just before I run all the features on my project to make sure that every step will be properly matched.

Anything else I can help with?

triskweline commented 12 years ago

Alright. I pushed a fix for this issue as a new gem version 1.8.3.

I did however fix this in a slightly different way. If activesupport is required for cucumber_factory to work, it should admit so in the gemspec.

We should probably get rid of this dependency eventually.

pkoch commented 12 years ago

Seems like a winner to me! Upgraded gem version to 1.8.3 and cucumber -d runs without any hitches.

Thank you for your attention. :)