search

makandra / geordi

Collection of command line tools used in our daily work with Ruby, Rails and Linux.
https://makandra.com/
MIT License
103 stars 17 forks source link

Update chromedriver version also for "geordi rspec" #191

Closed makmic closed 1 year ago

makmic commented 1 year ago

I noticed that the ChromedriverUpdater code is only being executed for the geordi cucumber command but not for geordi rspec. I suggest the version check should happen in each case as you can also write RSpec feature specs.

codener commented 1 year ago

Good point. However, we need to make sure it does not annoy developers on projects without feature specs.

tecden commented 1 year ago

Geordi should check per project if the chromedriver Gem is installed, and depending on that do the update. It should be logical that if you use chromedriver, you want to keep it up to date.

makmic commented 1 year ago

Please note that we do not use the chromedriver gem but binary: https://makandracards.com/makandra/29465-install-chromedriver-on-linux

makmic commented 1 year ago

You could however check for the selenium-webdriver gem.

tecden commented 1 year ago

The issue was fixed with the release of version 9.5.0