search

makandra / makandra-rubocop

makandra's default Rubocop configuration
MIT License
6 stars 1 forks source link

Disable Naming/RescuedExceptionsVariableName, or change its default #19

Closed foobear closed 4 years ago

foobear commented 4 years ago

Rubocop changed the default setting for Naming/RescuedExceptionsVariableName in 0.67.1 to require captured exceptions to be called e.

There is some kind of reasoning behind this, but I consider e a terrible variable name. I believe we usually use error, so we could change the default to that. Or, since we probably don not want to prevent "proper" names like parse_error, we could just disable the cop.

:+1: Disable :rocket: Change default to error :-1: Keep as is

triskweline commented 4 years ago

Vote to disable the cop.

jakobscholz commented 4 years ago

:rocket: would not allow 


...
rescue ArgumentError > argument_error
...
rescue StandardError > error
...
end