search

makandra / makandra-rubocop

makandra's default Rubocop configuration
MIT License
6 stars 1 forks source link

Disable RSpec/Capybara/SpecificFinders #41

Closed foobear closed 1 year ago

foobear commented 1 year ago

The RSpec/Capybara/SpecificFinders cop is provided by rubocop-rspec and enabled by default.

It disallows using find for ID selectors, i.e. find('#foo') should become find_by_id('foo').

I feel that using selectors is the most "natural" approach for us and that sometimes disallowing find causes more friction than it's helpful. IMO we should disable that cop in our config.

Please vote:

brunosedler commented 1 year ago

Majority voted for "disable", so I'll merge this MR and release a new version with the cop disabled