makcedward / nlp

:memo: This repository recorded my NLP journey.
https://makcedward.github.io/
1.07k stars 326 forks source link

returns lda instead of lsa #13

Open cstenkamp opened 2 years ago

cstenkamp commented 2 years ago

https://github.com/makcedward/nlp/blob/2f12277b952dca39d8a392fb14e5f086a562d269/sample/nlp-lsa_lda.ipynb?short_path=ab50a6b#L105

In the above line, you assign the result of the LSA to the variables x_train_lda, x_test_lda. Shouldn't it be lsa in both cases?