search

make-all / tuya-local

Local support for Tuya devices in Home Assistant
MIT License
1.34k stars 520 forks source link

Enhancement: add a user directory in which we can put our own devices files #2290

Open jmcollin78 opened 1 month ago

jmcollin78 commented 1 month ago

Your integration is first class and save my life so many times with TuYa devices...

But I have some specific devices files, customized for my needs, and each time I update the integration I need to put my specific files into custom_components/tuya_local/devices

If possible, I would like that tuya_local search also in a specific user directory (in /config/tuyalocal_devices for example). This user specific directory is persistant after a restart or reinstallation or update of tuyalocal.

make-all commented 1 month ago

This has been requested before, but is not something that is desirable in my opinion, as it would encourage hoarding rather than sharing, which goes against the spirit of open source software. localtuya exists for those who want to configure something differently for themselves.

jmcollin78 commented 1 month ago

Hello, thank you for your reply. I understand the point "hoarding rather than sharing" but in my case, I have proposed the device.yaml file and it is still not included into the tuya-local. So each time, I upgrade, I have to copy manually the files from a backup. Looking for your backlog I understand you have many many devices to integrate and I understand it is difficult to deal with so much issues.

So it could help for all people that are waiting for the official integration update.

EDIT: my proposal https://github.com/make-all/tuya-local/issues/2108 . I think you prefer MR than issue. Are you taking into account some issues with the device file in attachement ?

make-all commented 1 month ago

In this case, supplying logs (or since the device is already configured, diagnostics) is essential, as without them I have no way to evaluate the contribution. If you submit as a PR, I can have more confidence that you understand development practice and will continue to maintain it, but for contributions as part of an issue my assumption is that I will end up responsible for any flaws so I need the information to check it for it to be prioritised.

bdf0506 commented 1 month ago

I agree with the OP here. I’ve had instances where I’ve submitted PRs and the maintainer has asked me to make modifications to fit the project’s theme. That’s fine and all, but once I make the changes to get the PR accepted I typically keep my original file and overwrite the file in the downloaded instance. The result? I update this repo like twice a year. With a user directory, I would do updates to pretty much each release. Feel like a user directory is relatively small ask all things considered.

jmcollin78 commented 1 month ago

I agree with the OP here. I’ve had instances where I’ve submitted PRs and the maintainer has asked me to make modifications to fit the project’s theme. That’s fine and all, but once I make the changes to get the PR accepted I typically keep my original file and overwrite the file in the downloaded instance. The result? I update this repo like twice a year. With a user directory, I would do updates to pretty much each release. Feel like a user directory is relatively small ask all things considered.

This is typically my use case.