search

make-all / tuya-local

Local support for Tuya devices in Home Assistant
MIT License
1.41k stars 542 forks source link

Update stl_siren.yaml #2384

Closed VladimirTuzovGitHub closed 1 month ago

VladimirTuzovGitHub commented 1 month ago

The final integration is fully tested. Please update this code. Thank you very much for your support!

make-all commented 1 month ago

I don't see this as an improvement, sorry.

VladimirTuzovGitHub commented 1 month ago

Hello! The improvements are that your code does not have the setting for selecting the siren sound and setting the siren sound time. We discussed this in the topic https://github.com/make-all/tuya-local/issues/2350. I assume that these settings are important in the integration so that any user can configure them from the HA interface and does not need to do it through the Tuya application, which is very inconvenient.

make-all commented 1 month ago

The settings are there in the siren entity, they can be sent as parameters to the siren.turn_on action.

https://www.home-assistant.io/integrations/siren/#action-sirenturn_on

VladimirTuzovGitHub commented 1 month ago

I am talking about basic settings that will be available to the average user in a human-readable interface, and not through event or parameter calls in automations. In your configuration, in the very essence of the serena, there are only attributes of melodies and time in the form of a list.