search

make-files / makefiles

A library of opinionated Makefiles for popular programming languages.
https://makefiles.dev
MIT License
4 stars 5 forks source link

install-protoc fails on protobuf release candidate #122

Open na4ma4 opened 6 months ago

na4ma4 commented 6 months ago 
$ .makefiles/pkg/protobuf/v2/bin/install-protoc "$(pwd)/rsca/artifacts/protobuf"
~/grit/github.com/na4ma4/rsca/rsca/artifacts/protobuf ~/grit/github.com/na4ma4/rsca
curl: (56) The requested URL returned error: 404

because the line to check egreps on [0-9]+.[0-9]+

$ curl --head --silent https://github.com/protocolbuffers/protobuf/releases/latest | grep -i '^Location:' | egrep -o '[0-9]+.[0-9]+'
27.0
$ curl --head --silent https://github.com/protocolbuffers/protobuf/releases/latest | grep -i '^Location:'
location: https://github.com/protocolbuffers/protobuf/releases/tag/v27.0-rc1
jmalloc commented 6 months ago

@danilvpetrov I think this was fixed now right?

jmalloc commented 6 months ago

Hmm, I guess not actually - they've just made a new tag.