search

make-files / makefiles

A library of opinionated Makefiles for popular programming languages.
https://makefiles.dev
MIT License
4 stars 5 forks source link

Allow Telepresence remote ports to be specified #97

Closed ezzatron closed 2 years ago

ezzatron commented 2 years ago

This PR adds a mechanism to specify a default remote port to use for Telepresence intercepts.

Expected usage in a multi-port project's Makefile:

TELEPRESENCE_SERVICE_REMOTE_PORT ?= api

Then to intercept the default port, run commands like:

make intercept
make intercept-run

Or to intercept a different port, run commands like:

TELEPRESENCE_SERVICE_REMOTE_PORT=observability make intercept
TELEPRESENCE_SERVICE_REMOTE_PORT=observability make intercept-run
ezzatron commented 2 years ago

@deslittle @ahaw023 FYI

ezzatron commented 2 years ago

@jmalloc Would you prefer to hold off on merging this if you're keen to try the multiple port intercept idea? This might help alleviate some issues we're seeing right now, but there are other potential fixes too.

jmalloc commented 2 years ago

I do want to try the multiple-port intercepts; I need it for nomad-fake-operator at a minimum. But if this is necessary/useful now go ahead and merge it.

ahaw023 commented 2 years ago

hmmm i would have preferred holding off till we could have a chat on monday about this.

there are a couple of other things we might want to do to simplify this