make-software / casper-wallet

Securely manage your CSPR tokens, interact with dapps, and sign transactions with Casper Wallet, the go-to self-custody wallet for the Casper Network.
https://casperwallet.io
Apache License 2.0
22 stars 5 forks source link

Checksum validation feature | Inform users of mixed case checksum error during transaction #202

Open adammake opened 2 years ago

adammake commented 2 years ago

Requirements If a public key recipient in a proposed deploy has characters which have changed their casing an not longer produce a valid checksum display the following error message to the user: “The public key you provided contains mixed-case characters that don’t result in a valid checksum. Please check if the public key is correct”

Acceptance Criteria Pre-conditions: Add 'Invalid Transfer Deploy' button on the playground app Logic that is creating a valid deploy should alter any lower case letter within the target public key to a respective upper case one (i.e. c => C)

Steps to reproduce:

  1. Connect with a playground app
  2. Click 'Invalid Transfer Deploy' button
  3. Click on 'Sign' button

Expected Result: Displaying the following error message to the user in Casper Wallet: “The public key you provided contains mixed-case characters that don’t result in a valid checksum. Please check if the public key is correct” - this error would display as designed in Figma

Implementation details:

Implement a following page:

Screen Shot 2022-10-13 at 6 47 23 PM
piotrwitek commented 2 years ago

@vladimir-gachkovsky your next task

piotrwitek commented 2 years ago

couldn't find checksum in the casper-js-sdk, and it turn out that was not implemented, changing to blocked it's implemented in the upstream depoendency

piotrwitek commented 1 year ago

Need to create an implementation details ticket