search

make-web-au / module-extender-for-divi

Extend Divi theme for wordpress with custom modules.
5 stars 0 forks source link

Ideas for improvements #2

Open lukewatts opened 7 years ago

lukewatts commented 7 years ago

I want to add some thing to this plugin...

  1. PHPUnit Tests
  2. Setup Travis CI to test against all versions of PHP and HHVM
  3. Autoloading (PSR-0 or PSR-4)
  4. Add ability to create modules via plugin/drop-ins instead of adding them to Child theme
  5. Use Twig templates to render the output HTML (which is currently a messy sprintf). Alternatively simply use an output buffer and an include html.php file in each modules.
  6. Better documentation on the various field types and setting them up.
  7. Add to packagist (Depends on 2/3)

Sound good? I'll be implementing this anyways on my fork but I'm happy to submit pull requests and talk about conventions etc. if you're interested

lukewatts commented 7 years ago

Also I would say it's safe to imlement PSR-4 and Composer seeing as WordPress has deprecated support for PHP < 5.4. This also means you can adopt the short array syntax

AndrewFeeney commented 7 years ago

Hi @lukewatts,

Thanks for your comment, and Pull Request. I'd love to see your ideas for improving the plugin. If you'd like to submit your ideas via PR to the develop branch, that would be great.

lukewatts commented 7 years ago

So made a start on some of this earlier in the week. Because of the order things get initialized the theme modules get loaded after plugins...so making plugins for adding modules won't work unless using the Divi Builder plugin. But I have another idea on making it easier to setup a new module within the theme without needing to do the setup manually.

AndrewFeeney commented 7 years ago

Look forward to seeing your ideas.