Cleanup css throughout entire site

[jonfroehlich]

Remove unnecessary css includes on each html file and eliminate unused css tags. Maybe there is a tool to help with this?

[higherdefender]

I agree. CSS is totally a mess right now!

[htadeusiak]

I have attached my CSS report. The two major changes I would like to consider is adding a preprocessor and adopt a naming convention. I talk about both of these in the report in more detail. The report is heavily focused on good CSS principles to follow how we should implement them to improve the sites CSS architecture.

Makeability CSS Report.pdf

[jonfroehlich]

This is awesome Hank. Thank you for your work in clearly doing the background research, exploring tools, writing up a thoughtful report, and proposing a plan.

I would like to move forward with steps 1 and 2 in your proposal, which include: "Run all CSS through a CSS analysis tool and fix errors" and "Find and delete unused CSS." I think we should then engage in a larger discussion about the other steps as they would require a pretty massive rearchitecting of our current CSS and also require significant effort.

Jon

On Sat, Feb 9, 2019 at 6:32 PM Hank Tadeusiak notifications@github.com wrote:

I have attached my CSS report. The two major changes I would like to consider is adding a preprocessor and adopt a naming convention. I talk about both of these in the report in more detail. The report is heavily focused on good CSS principles to follow how we should implement them to improve the sites CSS architecture.

Makeability CSS Report.pdf https://github.com/jonfroehlich/makeabilitylabwebsite/files/2848464/Makeability.CSS.Report.pdf

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jonfroehlich/makeabilitylabwebsite/issues/664#issuecomment-462098062, or mute the thread https://github.com/notifications/unsubscribe-auth/ABi-9fDSTb_6pzAM-E9EBNBOxd8pc2DJks5vL4TMgaJpZM4Xa22h .

-- Jon Froehlich Associate Professor Paul G. Allen School of Computer Science & Engineering University of Washington http://www.cs.umd.edu/~jonf/ http://makeabilitylab.io @jonfroehlich https://twitter.com/jonfroehlich - Twitter

[higherdefender]

Thank you for compiling this Hank! I learned from reading your report :)

On Sun, Feb 10, 2019 at 6:36 AM Jon Froehlich notifications@github.com wrote:

This is awesome Hank. Thank you for your work in clearly doing the background research, exploring tools, writing up a thoughtful report, and proposing a plan.

I would like to move forward with steps 1 and 2 in your proposal, which include: "Run all CSS through a CSS analysis tool and fix errors" and "Find and delete unused CSS." I think we should then engage in a larger discussion about the other steps as they would require a pretty massive rearchitecting of our current CSS and also require significant effort.

Jon

On Sat, Feb 9, 2019 at 6:32 PM Hank Tadeusiak notifications@github.com wrote:

I have attached my CSS report. The two major changes I would like to consider is adding a preprocessor and adopt a naming convention. I talk about both of these in the report in more detail. The report is heavily focused on good CSS principles to follow how we should implement them to improve the sites CSS architecture.

Makeability CSS Report.pdf < https://github.com/jonfroehlich/makeabilitylabwebsite/files/2848464/Makeability.CSS.Report.pdf

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/jonfroehlich/makeabilitylabwebsite/issues/664#issuecomment-462098062 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABi-9fDSTb_6pzAM-E9EBNBOxd8pc2DJks5vL4TMgaJpZM4Xa22h

.

-- Jon Froehlich Associate Professor Paul G. Allen School of Computer Science & Engineering University of Washington http://www.cs.umd.edu/~jonf/ http://makeabilitylab.io @jonfroehlich https://twitter.com/jonfroehlich - Twitter

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jonfroehlich/makeabilitylabwebsite/issues/664#issuecomment-462137990, or mute the thread https://github.com/notifications/unsubscribe-auth/ALGPL91SL-dbX2LkrsWhzWyVkQmNiUIWks5vMC6LgaJpZM4Xa22h .

[htadeusiak]

Thanks. Would you like me to go through the bootstrap CSS files as well and take out all unused CSS. Or keep it strictly to our CSS files?

[jonfroehlich]

Strictly to ours for now

Sent from my iPhone

On Feb 11, 2019, at 2:15 PM, Hank Tadeusiak notifications@github.com wrote:

Thanks. Would you like me to go through the bootstrap CSS files as well and take out all unused CSS. Or keep it strictly to our CSS files?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[htadeusiak]

I am un-assigning myself from this after speaking with Jon. All that has been done is (1) any unnecessary css selectors were removed;(2) the format of the CSS files were updated. They are now formatted to 2 space indenting and a line between each selector.

Going forward, I would refer to the pdf I have attached. It has proposed steps explaining them in detail. Then next step would 3 in the document. 3, 4, 5, and 6 are all related and should be down around the same time. This is a fairly big task considering how much CSS there is on the website since it would require to rename/restructure most of it.

Everything I have learned while assigned to this is in the attached pdf.

Makeability.CSS.Report.pdf

[jonfroehlich]

Chrome has a CSS audit tool (type ctrl-shift-p or cmd-shift-p to enable).

[jonfroehlich]

Yikes, we scored an F 0/100 on yellowlab.tools audit!