search

makebrainwaves / BrainWaves

An easy-to-use platform for EEG experimentation in the classroom
MIT License
60 stars 26 forks source link

Project "Jiffy Lube": TypeScript, Continuous Integration, React 16.13, etc. #131

Closed jdpigeon closed 3 years ago

teonbrooks commented 4 years ago

so modern, so sleek!

teonbrooks commented 4 years ago

I see that we now have automated testing here, cool! do you think we could also use this for the builds. i know with circleci, it can store generated artifacts

jdpigeon commented 4 years ago

Yes! CI is set up to package the app on every OS. It looks to me like it should also publish the builds so that they're accessible as artifacts on Github. If they're not when we get the builds passing I'll make sure we get that set up

teonbrooks commented 3 years ago

bluetooth issues should be resolved with this PR. closes #32, #116

jdpigeon commented 3 years ago

Wooo! We got artifacts!!

https://github.com/makebrainwaves/BrainWaves/releases/tag/untagged-f20fb7aa8bffc9778dbf

teonbrooks commented 3 years ago

awesome, good to see the modernization!

i'm having some difficulty on my Mac with running the app, from the artifacts generated, it just opens up a blank screen. i've then updated my local dev environment and I get the same thing. I do get this traceback though:

Uncaught Error: Cannot find module 'xpc-connection'
Require stack:
- /Users/tbrooks/codespace/BrainWaves/app/node_modules/noble/lib/mac/highsierra.js
- /Users/tbrooks/codespace/BrainWaves/app/node_modules/noble/lib/mac/bindings.js
- /Users/tbrooks/codespace/BrainWaves/app/node_modules/noble/lib/resolve-bindings.js
- /Users/tbrooks/codespace/BrainWaves/app/node_modules/noble/index.js
- /Users/tbrooks/codespace/BrainWaves/app/node_modules/noble-winrt/index.js
- /Users/tbrooks/codespace/BrainWaves/app/node_modules/bleat/dist/adapter.noble.js
- /Users/tbrooks/codespace/BrainWaves/app/node_modules/bleat/index.js
- /Users/tbrooks/codespace/BrainWaves/app/app.html
    at Module._resolveFilename (internal/modules/cjs/loader.js:798)
    at Function../lib/common/reset-search-paths.ts.Module._resolveFilename (electron/js2c/renderer_init.js:752)
    at Module._load (internal/modules/cjs/loader.js:691)
    at Function.Module._load (electron/js2c/asar.js:748)
    at Module.require (internal/modules/cjs/loader.js:853)
    at require (internal/modules/cjs/helpers.js:74)
    at Object.<anonymous> (node_modules/noble/l…mac/highsierra.js:7)
    at Object.<anonymous> (node_modules/noble/l…c/highsierra.js:842)
    at Module._compile (internal/modules/cjs/loader.js:968)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:986)

should I make a separate issue for this?

jdpigeon commented 3 years ago

I though that error looked familiar :) https://github.com/makebrainwaves/BrainWaves/issues/13

FWIU, this error should only apply when you're building the app on Mac, so this might not explain why the compiled artifact doesn't work. Let's get to the point where you can successfully build on Mac locally and then investigate why published artifacts aren't working.