search

makebrainwaves / BrainWaves

An easy-to-use platform for EEG experimentation in the classroom
MIT License
60 stars 26 forks source link

Finalize CI Secretes #153

Closed jdpigeon closed 3 years ago

jdpigeon commented 3 years ago

Looks like you did most of the work to put our keys in CI last September, @teonbrooks!

I think the missing piece is that the env variables actually used in the app didn't match what we added to CI. I've updated them here to match, which should be all we need.

teonbrooks commented 3 years ago

just curious, does the GitHub secrets support json to keep the secrets in one file or is it best specified individually like I did. I had done it both ways but I didn't get it to work (needed to add the part to webpack)

teonbrooks commented 3 years ago

closes #141

jdpigeon commented 3 years ago

Based on the github docs and another tutorial I saw, storing secrets as strings is the most common way to do things. I don't think storing them as a single json is necessarily desirable.

Another thing I noticed is that we don't actually use the username and password anymore since the update to the new Cortex SDK. We can remove those secrets whenever.