Closed teonbrooks closed 4 years ago
you can follow along with the wishlist of things for brainwaves x pyodide here.
Does this PR deprecate #74?
yes. closes #74.
I think we'll make this PR the place for a complete Jupyter replacement. Hopefully can find some time to get to the matplotlib integration step soon.
cool. getting a matplotlib plot to work should be straightforward. there is just a little bit we would need to tweak but I have it documented. getting the epochs viewer will be a bit more work. i think it would be a matter of getting some event listeners in place. happy to hack on this with you, should be around town for a bit
@jdpigeon should we make a to-do list of things we have left to address here?
At this point we have been able to handle the follow:
We have the following left:
Some things to keep in mind:
hey @jdpigeon, could you rebase this branch to the latest master and I will then cherry-pick some of the commits from my local branch to get it all up-to-date
stumbled upon this, which might be useful: https://pyodide.readthedocs.io/en/stable/using_pyodide_from_webworker.html https://github.com/iodide-project/pyodide/blob/master/src/webworker.js
since the data processing is happening in python world and js only need images, maybe those can be passed with the onMessage. it will take python off the main thread and speed up the app.
stumbled upon this, which might be useful: https://pyodide.readthedocs.io/en/stable/using_pyodide_from_webworker.html https://github.com/iodide-project/pyodide/blob/master/src/webworker.js
since the data processing is happening in python world and js only need images, maybe those can be passed with the onMessage. it will take python off the main thread and speed up the app.
That sounds brilliant. Thanks Teon
Moving this branch from teonbrooks to makebrainwaves. Should be easier to bring through the home stretch that way.
This is the initial attempts to gut out the dependency on a local Python kernel and the communication between the app and kernel. Pyodide offers a full working kernel implemented in WebAssembly. This PR attempts to identify pain points, necessary patches for upstream dependencies, and testing ground for change.