search

makebrainwaves / BrainWaves

An easy-to-use platform for EEG experimentation in the classroom
MIT License
60 stars 26 forks source link

Update jspsych-react version #80

Closed jdpigeon closed 4 years ago

jdpigeon commented 5 years ago

After porting jspsych-react over to webpack 4, I updated the version used in BrainWaves. The new version of jspsych-react also includes the newest version of jspsych-react.

Experiments seem to run fine, but I would appreciate someone's help testing this version of the app to make sure response behaviour is preserved.

Also, there are some warnings complaining about the wrong rt_method being defined. However, the method we're using in our plugins, "date", still appears to be supported by jsPsych.

teonbrooks commented 5 years ago

hey @jdpigeon, this is currently pointing to local copy of the jspsych-react. I guess this is still wip?

jdpigeon commented 5 years ago

Yes, I meant to update it after publishing to npm. Thanks for catching this

teonbrooks commented 4 years ago

I noticed something strange: if I go to review and click the preview experiment, it works, but if I do it from the start experiment path, it breaks. any idea what's going on here? i've rebased it the latest point in master

teonbrooks commented 4 years ago

issue mentioned above seems resolved. just did a bit of QA and it works. merging. thanks @jdpigeon!