search

makebrainwaves / BrainWaves

An easy-to-use platform for EEG experimentation in the classroom
MIT License
61 stars 26 forks source link

Separate labjs component into separate repo #87

Closed teonbrooks closed 4 years ago

teonbrooks commented 5 years ago

A few things:

  1. Could you open a PR with the branch so that I could make some comments on the code.
  2. I think we would like to echo the structure of the jspsych-react component with the props given there. I think you can keep the name Experiment, or maybe we should change both to ExperimentWindow
  3. the labjs component has the lab.js files included instead having them in the package.json file. It's likely that we would want to maintain the current version of lab.js so I would suggest adding it there
Yury-Shevchenko commented 5 years ago
  1. I've opened "Lab.js integration" PR
  2. Changed it to ExperimentWindow
  3. I guess, we have to discuss how to turn it to package.json file - it's not clear for me now what exactly you mean.
teonbrooks commented 4 years ago

closing because lab.js is now served via npm and the React component we create from it isn't particularly custom, just window sizing. Not necessary for separate repo maintenance