[Needs QA] Update Emotiv utils to use Cortex 2.0 API

makebrainwaves / BrainWaves

An easy-to-use platform for EEG experimentation in the classroom

MIT License

61 stars 26 forks source link

[Needs QA] Update Emotiv utils to use Cortex 2.0 API #94

Closed jdpigeon closed 4 years ago

jdpigeon commented 4 years ago

This PR updates the Emotiv utils (emotiv.js and cortex.js) to use the new Cortex API. The changes were made in accordance with Emotiv's V1.x to V2.x update doc: https://emotiv.gitbook.io/cortex-api/changes-from-v1-to-v2

I do not have an emotiv with me and so have not been able to test these changes yet. QA with a physical device will be necessary before we can merge this in

teonbrooks commented 4 years ago

I will QA this tomorrow. thanks @jdpigeon!

teonbrooks commented 4 years ago

looking over the documentation (link above doesn't work anymore) here: https://emotiv.gitbook.io/cortex-api/release-notes#changes-from-cortex-1-x-to-cortex-v-2-0, I am seeing a few things:

anonymous sign in is no longer allowed
the user must agree to the EULA either through their EMOTIV app (don't have) or through the request. I didn't see a section in the cortex.js.
- it's also noted Most of the methods of the API will fail if the user didn't approve your application.