search

makeclean / occ_faceter

GNU Lesser General Public License v2.1
4 stars 6 forks source link

Faceting shared faces with materials #6

Closed johnnonweiler closed 4 years ago

johnnonweiler commented 4 years ago

Add handling of shared faces (faceting them only once, and setting a tag for forward or reverse sense of normals), and also reading and writing of materials (e.g. "mat:vacuum").

Either reading a JSON list of STEP files with materials for each file, or reading a BREP file with an associated JSON file giving a material for each solid.

This PR also includes some refactoring and other minor changes, e.g. adding a missing call to "delete".

There's clearly room for improvement, in particular it would be better to have more tests, and some things should be renamed - having one file called "dagmc_faceter.cc" and another called "occ_faceter.cc" is clearly confusing.

johnnonweiler commented 4 years ago

The executables have already been unified, so there is now one executable where there were three.

If you would prefer to have fewer source files, then I could put the step_2_breps() method in steps2h5m.cc, and remove steps2breps.cc?

shimwell commented 4 years ago

this works for the basic (20 volume) geometry I have been testing