Closed queenkjuul closed 2 years ago
Can you merge in the changes I just added to master
? It should automatically deploy to Netlify after you do that so I can preview your changes.
should be good
It looks like you still need to merge in the changes for the Netlify config - looking at your repo it looks like it's still 3 commits behind.
I can just do it myself if you'd like to, I just need to know if you're fine with that.
hmm I went to my repo and hit "fetch upstream" (in github)
you are welcome to do whatever you like though
on my end though it says the most recent commit was 14 min ago....so I think I am up to date, do you need to fetch my fork again?
Yeah, you need to merge the master
branch in your repository into patch-1
so you have the Netlify config inside of this PR.
Name | Link |
---|---|
Latest commit | c6a1c90e8571121da29066ebcac39eb9dc6f82e2 |
Latest deploy log | https://app.netlify.com/sites/makedeb-docs/deploys/62435f7df9d28d00087c24c3 |
Deploy Preview | https://deploy-preview-29--makedeb-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
oh lol i gotcha. sorry I use gitlab at work and am pretty new to this cross-fork pull request workflow
All good :)
Preview looks fine too, I'll go ahead and get this merged then
I accidentally opened the issue on the wrong project lol my bad (in my defense it was very late and I had consumed a few adult beverages)
makedeb/makedeb-docs#30
i think this should fix it for you but I mostly just wanted yall to be aware of the problem. I am not sure how to test this to be 100% sure but when I installed the repo I used the same proget URL from a few lines above, so that's what I copied here, so it makes sense in my mind.
anyway cheers