search

makedeb / mist

The official command-line interface for the makedeb Package Repository
GNU General Public License v3.0
72 stars 7 forks source link

#28: non-zero exit codes for 'list' and 'search' not found: initial commit #29

Closed tonky closed 1 year ago

tonky commented 2 years ago

Hey Hunter, saw you post on mist in /r/linux yesterday!

As a fan of Arch/AUR(though using PopOS atm) i gave it a try and installed nodejs and npm from MPR - good stuff, i'd say!

Then i checked out the mist repo - and bam, it's in rust!

Well, i have some time on my hands and some rust experience, so why not contribute to a good project?!

Here's the initial draft of #28.

Given that there are a lot of hidden assumptions here(expected test structure? exitcode::USAGE for missing 'package base'? rest of subcommands?), i'd like to have some input from you on structure/tests/overall picture.

Feel free to comment on PR, so it can be improved as you see fit.

hwittenborn commented 2 years ago

Hey, thanks for the kind words :) thanks for the MR too, it's always great to get some contributors in here!

I'm out right now, but I'll be home in a few hours and then I can get this looked over

hwittenborn commented 2 years ago

Sorry for the delayed comments on all that, looks like I forgot to submit my review and they all remained in a pending state on GitHub :p

hwittenborn commented 1 year ago

I just pushed some changes to remove that hanging issue you experienced, I also added a Justfile so the sudo chown and sudo chmod stuff doesn't have to be repeated everywhere. I'm probably gonna want to set up some stuff with bats after this for the end-to-end tests - do you want to tackle those or do you want me to get those done?

Let me know if you're having any trouble with my changes either, I'll be available to help

hwittenborn commented 1 year ago

Sorry for all these dummy commits, I can't do much local testing atm - I'm just doing one last test and then this should all be ready to merge though - lmk if you have any questions or comments about anything, I'll get it merged after that.

hwittenborn commented 1 year ago

I'm gonna go ahead and get this merged @tonky, we can get things changed still as you need though, just let me know.

Thanks a ton for the contribution! :)

tonky commented 1 year ago

Thanks for seeing this though, Hunter! Sorry fo my disappearance, some real life stuff got in the way :)

hwittenborn commented 1 year ago

Not a problem, there isn't too much of a rush for any of this. Thanks for letting me know though!